-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Closed
flutter/engine
#26756Labels
P1High-priority issues at the top of the work listHigh-priority issues at the top of the work lista: tests"flutter test", flutter_test, or one of our tests"flutter test", flutter_test, or one of our testsc: contributor-productivityTeam-specific productivity, code health, technical debt.Team-specific productivity, code health, technical debt.engineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.
Description
We do this currently so we can test internal implementations. However, this is really brittle - it breaks when someone adds a new import aliased a certain way. We also recently had a case where a unit test was added modeled after this one incorrectly, which ended up hiding the fact that its implementation wasn't quite working right.
We should figure out a way to either expose the relevant bits that are internal or make sure we can test the relevant bits through the public API.
Metadata
Metadata
Assignees
Labels
P1High-priority issues at the top of the work listHigh-priority issues at the top of the work lista: tests"flutter test", flutter_test, or one of our tests"flutter test", flutter_test, or one of our testsc: contributor-productivityTeam-specific productivity, code health, technical debt.Team-specific productivity, code health, technical debt.engineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.