Skip to content

[windows]: some flutter_windows_unittests need skia's software renderer #188173

Description

@gaaclarke

#188140 switches windows to use impeller by default. This breaks a handful of tests that require setup to reach beyond setting up a rendering context. We should make these tests run without skia.

Probably the easiest way to make that happen would be to link swiftshader to flutter_windows_unittests.exe.

  C:\b\s\w\ir\cache\builder\engine\src\out\ci/host_debug_test\flutter_windows_unittests.exe FlutterWindowsViewTest.AccessibilityHitTesting passed 0 / 2 times.
  C:\b\s\w\ir\cache\builder\engine\src\out\ci/host_debug_test\flutter_windows_unittests.exe FlutterWindowsViewTest.AddSemanticsNodeUpdate passed 0 / 2 times.
  C:\b\s\w\ir\cache\builder\engine\src\out\ci/host_debug_test\flutter_windows_unittests.exe FlutterWindowsViewTest.AddSemanticsNodeUpdateWithChildren passed 0 / 2 times.
  C:\b\s\w\ir\cache\builder\engine\src\out\ci/host_debug_test\flutter_windows_unittests.exe FlutterWindowsViewTest.CheckboxNativeState passed 0 / 2 times.
  C:\b\s\w\ir\cache\builder\engine\src\out\ci/host_debug_test\flutter_windows_unittests.exe FlutterWindowsViewTest.EnableSemantics passed 0 / 2 times.
  C:\b\s\w\ir\cache\builder\engine\src\out\ci/host_debug_test\flutter_windows_unittests.exe FlutterWindowsViewTest.KeyEventCallback passed 0 / 2 times.
  C:\b\s\w\ir\cache\builder\engine\src\out\ci/host_debug_test\flutter_windows_unittests.exe FlutterWindowsViewTest.KeySequence passed 0 / 2 times.
  C:\b\s\w\ir\cache\builder\engine\src\out\ci/host_debug_test\flutter_windows_unittests.exe FlutterWindowsViewTest.NonZeroSemanticsRoot passed 0 / 2 times.
  C:\b\s\w\ir\cache\builder\engine\src\out\ci/host_debug_test\flutter_windows_unittests.exe FlutterWindowsViewTest.OnFocusTriggersSendFocusViewEvent passed 0 / 2 times.
  C:\b\s\w\ir\cache\builder\engine\src\out\ci/host_debug_test\flutter_windows_unittests.exe FlutterWindowsViewTest.SizeChangeTriggersMetricsEventWhichHasDisplayId passed 0 / 2 times.
  C:\b\s\w\ir\cache\builder\engine\src\out\ci/host_debug_test\flutter_windows_unittests.exe FlutterWindowsViewTest.SubMenuExpandedState passed 0 / 2 times.
  C:\b\s\w\ir\cache\builder\engine\src\out\ci/host_debug_test\flutter_windows_unittests.exe FlutterWindowsViewTest.SwitchNativeState passed 0 / 2 times.
  C:\b\s\w\ir\cache\builder\engine\src\out\ci/host_debug_test\flutter_windows_unittests.exe FlutterWindowsViewTest.TestEmptyFrameResizes passed 0 / 2 times.
  C:\b\s\w\ir\cache\builder\engine\src\out\ci/host_debug_test\flutter_windows_unittests.exe FlutterWindowsViewTest.TooltipNodeData passed 0 / 2 times.
  C:\b\s\w\ir\cache\builder\engine\src\out\ci/host_debug_test\flutter_windows_unittests.exe FlutterWindowsViewTest.WindowResizeTests passed 0 / 2 times.

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Important issues not at the top of the work liste: impellerImpeller rendering backend issues and features requeststeam-engineOwned by Engine teamtriaged-engineTriaged by Engine team

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions