Skip to content

[rfw] Remove autoformat opt-out #187508

Description

@stuartmorgan-g

We have special logic in the repo tooling that allows rfw to opt some files out of autoformatting. That dates to when flutter/flutter wasn't autoformatted because Hixie didn't think the autoformatter did a good enough job with Flutter code, and so he didn't want it enforced on rfw.

Now that flutter/flutter uses autoformatting everywhere, I think we should remove the opt-out logic, and autoformat those files. It's not quite that easy though, because there are annotations used by custom logic in the coverage regression detector in rfw's custom_tests.sh, and the formatter moves some of those comments in a way that makes the script think coverage has regressed. We'll need to revisit the logic of that coverage detection.

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Important issues not at the top of the work listc: tech-debtTechnical debt, code quality, testing, etc.p: rfwRemote Flutter Widgets packagepackageflutter/packages repository. See also p: labels.team-ecosystemOwned by Ecosystem teamtriaged-ecosystemTriaged by Ecosystem team

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions