Skip to content

Parsing of android flutter shell args currently defaults to true #184581

Description

@gmackall

This was changed with
https://github.com/flutter/flutter/pull/182522/changes
See #182522 (comment)

We should give the flag definition a place for a default value, and then give each flag the default it had before, to restore the old behavior.

Note that we currently are checking if the key is present
https://github.com/flutter/flutter/blob/master/engine/src/flutter/shell/platform/android/io/flutter/embedding/engine/loader/FlutterLoader.java#L314

So this won't affect most cases, but the behavior for a flag with a typo in the value (Fasle), or no value, changed from defaulting from false to true for many of these flags.

Metadata

Metadata

Assignees

Labels

P1High-priority issues at the top of the work listfyi-engineFor the attention of Engine teamteam-androidOwned by Android platform team

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions