Skip to content

More systemically separate Flutter's image testing from Skia's images directory #182629

Description

@rphilli

Help us understand the severity of this issue

  • breakage; unable to contribute or trigger builds will no workarounds
  • inconvenient workarounds exist, but significant effort required
  • needed for a Flutter team-wide priority (already agreed upon)
  • nice-to-have; none of the above

What do you need help with

The Skia CL https://skia-review.git.corp.google.com/c/skia/+/1138796 added a new resources/images/rgb24prof.bmp file.

Unfortunately, the Flutter Web tests (specifically codecs_test.dart) try to run through all the images in resources/images and decode them.

The new image, apparently, can't be decoded by Safari and is blocking the Skia roll into Flutter.

The two simplest things I can think of two prevent such blockages are to either have a separate directory of test images over in Flutter or allow-list the images Flutter consumes from within Skia's resources/images directory.

Metadata

Metadata

Labels

P1High-priority issues at the top of the work lista: tests"flutter test", flutter_test, or one of our testsc: flakeTests that sometimes, but not always, incorrectly passengineflutter/engine related. See also e: labels.team-webOwned by Web platform teamtriaged-webTriaged by Web platform team

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions