#182519 enables all of the impeller/compiler/compiler_unittests.cc runtime target tests for all runtime targets: kRuntimeStageMetal, kRuntimeStageGLES, kRuntimeStageGLES3, kRuntimeStageVulkan, and kSkSL. (Previously, these tests ran only on kRuntimeStageMetal.)
Two of the tests, UniformsAppearInJson and PositionedUniformsAppearInJson fail when running with kRuntimeStageVulkan. They are disabled for these targets.
We should investigate why these are failing. It may potentially be due to bugs in our Vulkan shader compiler.
#182519 enables all of the
impeller/compiler/compiler_unittests.ccruntime target tests for all runtime targets:kRuntimeStageMetal,kRuntimeStageGLES,kRuntimeStageGLES3,kRuntimeStageVulkan, andkSkSL. (Previously, these tests ran only onkRuntimeStageMetal.)Two of the tests,
UniformsAppearInJsonandPositionedUniformsAppearInJsonfail when running withkRuntimeStageVulkan. They are disabled for these targets.We should investigate why these are failing. It may potentially be due to bugs in our Vulkan shader compiler.