Skip to content

[ios][pigeon] Make PigeonError Equatable #182480

Description

@hellohuanlin

Use case

FlutterError is equatable, so we can easily write this in unit test:

XCTAssertEqual(error, expectedError)

But after migrating to pigeon, PigeonError is not equatable anymore, so we had to manually write PigeonError extension conformance, or manually compare the properties inside PigeonError.

More Context: flutter/packages#10980 (comment)

Proposal

Consider making PigeonError Equatable.

This is a breaking change, since if plugin authors already write the extension to conform PigeonError to Equatable, it would fail to compile.

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Important issues not at the top of the work listc: new featureNothing broken; request for a new capabilityp: pigeonrelated to pigeon messaging codegen toolpackageflutter/packages repository. See also p: labels.platform-iosiOS applications specificallyteam-ecosystemOwned by Ecosystem teamtriaged-ecosystemTriaged by Ecosystem team

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions