-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Closed
Labels
a: error messageError messages from the Flutter frameworkError messages from the Flutter frameworka: tests"flutter test", flutter_test, or one of our tests"flutter test", flutter_test, or one of our testsf: integration_testThe flutter/packages/integration_test pluginThe flutter/packages/integration_test pluginr: fixedIssue is closed as already fixed in a newer versionIssue is closed as already fixed in a newer versionteam-toolOwned by Flutter Tool teamOwned by Flutter Tool teamtoolAffects the "flutter" command-line tool. See also t: labels.Affects the "flutter" command-line tool. See also t: labels.
Description
As far as I can tell, the tests for dev/integration_tests/hook_user_defines were never added to a CI build and currently don't run.
They also fail when running them locally with flutter test:
Unhandled exception:
Invalid argument(s): User-define `magic_value` must be an integer, found: null.
#0 main.<anonymous closure> (file:///Users/goderbauer/dev/flutter/dev/integration_tests/hook_user_defines/hook/build.dart:13:7)
#1 build (package:hooks/src/api/build_and_link.dart:158:18)
#2 main (file:///Users/goderbauer/dev/flutter/dev/integration_tests/hook_user_defines/hook/build.dart:10:9)
#3 _delayEntrypointInvocation.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:312:33)
#4 _RawReceivePort._handleMessage (dart:isolate-patch/isolate_patch.dart:193:12)
This failure is probably due to resolution: workspace in the package's pubspec.yaml. The workspace pubspec does not define a value for the magic_value user define. Only the package-local pubspec does. We probably don't want random test user defines in the root pubspec. Maybe this packages has to be removed from the workspace?
Steps necessary to close this issue:
- Fix the tests of
dev/integration_tests/hook_user_defines - Make these tests run on CI somewhere (maybe as parts of the tools integration test shard?) so they don't break again.
Metadata
Metadata
Assignees
Labels
a: error messageError messages from the Flutter frameworkError messages from the Flutter frameworka: tests"flutter test", flutter_test, or one of our tests"flutter test", flutter_test, or one of our testsf: integration_testThe flutter/packages/integration_test pluginThe flutter/packages/integration_test pluginr: fixedIssue is closed as already fixed in a newer versionIssue is closed as already fixed in a newer versionteam-toolOwned by Flutter Tool teamOwned by Flutter Tool teamtoolAffects the "flutter" command-line tool. See also t: labels.Affects the "flutter" command-line tool. See also t: labels.