[Google3 Bug]: NullPointerException on AccessibilityBridge #180381
Description
Help us understand the severity of this issue
- causing severe production issues e.g. malfunctions or data loss
- blocking next binary release
- blocking a client feature launch within a quarter
- nice-to-have but does not block a launch within the next quarter
Steps to reproduce
We haven't found a way to reproduce it yet.
Expected results
No crash.
Actual results
There are crashes: b/464096258
Code sample
On file AccessibilityBridge.java, in line 992, there is a recent change:
assert embeddedView != null;
// The embedded view is initially marked as not important at creation in the platform
// view controller, so we must explicitly mark it as important here.
embeddedView.setImportantForAccessibility(View.IMPORTANT_FOR_ACCESSIBILITY_AUTO);Note, the assert is usually ignored in production build. Here we should do an if condition check, just like other places, for example, line 1643 and line 2031.
I suggest the code to be:
if (embeddedView != null) {
// The embedded view is initially marked as not important at creation in the platform
// view controller, so we must explicitly mark it as important here.
embeddedView.setImportantForAccessibility(View.IMPORTANT_FOR_ACCESSIBILITY_AUTO);
result.addChild(embeddedView);
}Screenshots or Video
Screenshots / Video demonstration
[Upload media here]
Logs
Logs
[Paste your logs here]Flutter Doctor output
NA.