Skip to content

[Impeller] OpenGL commands may use the incorrect viewport. #176945

Description

@chinmaygarde

Regression introduced in flutter-team-archive/engine#56902.

One of the aims of the linked patch was to remove redundant calls to Viewport and DepthRange. It did this by moving the primary call to Viewport outside of the loop that iterated over the commands and only updating the viewport for commands that explicitly specified a viewport.

But this introduced a subtle bug where commands after one that specified a viewport that also did not specify their own viewport would get the viewport of a previous command (instead of one that covered the entire extent of the render pass).

This is an OpenGL specific regression.

Metadata

Metadata

Assignees

Labels

P1High-priority issues at the top of the work listc: regressionIt was better in the past than it is nowe: impellerImpeller rendering backend issues and features requeststeam-engineOwned by Engine teamtriaged-engineTriaged by Engine team

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions