-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Closed
flutter/packages
#10700Labels
P3Issues that are less important to the Flutter projectIssues that are less important to the Flutter projectp: mustache_templateThe mustache_template packageThe mustache_template packagepackageflutter/packages repository. See also p: labels.flutter/packages repository. See also p: labels.team-ecosystemOwned by Ecosystem teamOwned by Ecosystem teamtriaged-ecosystemTriaged by Ecosystem teamTriaged by Ecosystem team
Description
The Gemini review of the initial import of mustache_template flagged some latent issues in the error handling, which would be good to resolve:
- There are several lines that call
_errorbut don't throw the returned exception, making it basically a no-op, when it seems like it was intended to throw an exception. - Some code that should be unreachable throws
Exceptionwhen a more idiomatic Dart approach would be to throwStateError.
Metadata
Metadata
Assignees
Labels
P3Issues that are less important to the Flutter projectIssues that are less important to the Flutter projectp: mustache_templateThe mustache_template packageThe mustache_template packagepackageflutter/packages repository. See also p: labels.flutter/packages repository. See also p: labels.team-ecosystemOwned by Ecosystem teamOwned by Ecosystem teamtriaged-ecosystemTriaged by Ecosystem teamTriaged by Ecosystem team