-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Closed
Labels
c: contributor-productivityTeam-specific productivity, code health, technical debt.Team-specific productivity, code health, technical debt.engineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.platform-windowsBuilding on or for Windows specificallyBuilding on or for Windows specifically
Description
In Windows builds, we override target_os to win. For android-arm and android-arm64 builds of gen_snapshot we should be building with target_os="android". Previously this resulted in #17387.
We should eliminate this override and fix up the rest of the build to correctly support building gen_snapshot (and ideally the engine) on Windows; this would also make it easier for Windows developers to contribute to the engine.
Metadata
Metadata
Assignees
Labels
c: contributor-productivityTeam-specific productivity, code health, technical debt.Team-specific productivity, code health, technical debt.engineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.platform-windowsBuilding on or for Windows specificallyBuilding on or for Windows specifically