Skip to content

Impeller uses deprecated AChoreographer_postFrameCallback #173656

@rmacnak-google

Description

@rmacnak-google

Attempting to build the engine against android_apl_level 35, the minimum for RISC-V, results in

../../flutter/impeller/toolkit/android/proc_table.h:124:3: warning: 'AChoreographer_postFrameCallback' is deprecated: first deprecated in Android 29 - Use AChoreographer_postFrameCallback64 instead [-Wdeprecated-declarations]
  124 |   FOR_EACH_ANDROID_PROC(DEFINE_PROC);
      |   ^
../../flutter/impeller/toolkit/android/proc_table.h:42:10: note: expanded from macro 'FOR_EACH_ANDROID_PROC'
   42 |   INVOKE(AChoreographer_postFrameCallback, 24)                   \
      |          ^
../../flutter/third_party/android_tools/ndk/toolchains/llvm/prebuilt/linux-x86_64/sysroot/usr/include/android/choreographer.h:157:6: note: 'AChoreographer_postFrameCallback' has been explicitly marked deprecated here
  157 | void AChoreographer_postFrameCallback(AChoreographer* choreographer,
      |      ^
1 warning generated.

Unfortunately, the engine treats deprecation notices as errors, so this is fatal.

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Important issues not at the top of the work liste: impellerImpeller rendering backend issues and features requestsengineflutter/engine related. See also e: labels.good first issueRelatively approachable for first-time contributorsplatform-androidAndroid applications specificallyr: fixedIssue is closed as already fixed in a newer versionteam-engineOwned by Engine teamtriaged-engineTriaged by Engine team

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions