Skip to content

Remove schedule_during_release_override: true and use two targets instead #168913

@matanlurey

Description

@matanlurey

In #168709 we added a workaround, schedule_during_release_override: true:

targets:
  - name: Linux docs_publish
    schedule_during_release_override: true

Unfortunately it does not completely fix every issue that was originally regressed in #162557, namely now Linux docs_publish is run twice - once on Linux flutter_release_builder, and once on post-submit tasks scheduled after the release builder.

As far as I can tell this has no negative side-effects other than being wasteful (GCS buckets should be the same, output should be the same).

To make everything simpler, both in the recipes, and not having to add code elsewhere, we should just do:

targets:
  - name: Linux docs_publish
    enabled_branches: [master]

  - name: Linux docs_publish_release
    scheduler: release

To do this:

  • Add support for scheduler: release in the is is_release_candidate: branch of release_builder.py
  • Split the target branches in master
  • Split the target branches in flutter-3.32-candidate.0
  • Remove schedule_during_release_override

Metadata

Metadata

Assignees

Labels

P1High-priority issues at the top of the work listc: tech-debtTechnical debt, code quality, testing, etc.infra: recipesIssues with flutter/recipesinfra: releaseRelease-related requests and toolingteam-infraOwned by Infrastructure teamtriaged-infraTriaged by Infrastructure team

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions