-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Closed
flutter/cocoon
#4758Labels
P1High-priority issues at the top of the work listHigh-priority issues at the top of the work listc: tech-debtTechnical debt, code quality, testing, etc.Technical debt, code quality, testing, etc.infra: recipesIssues with flutter/recipesIssues with flutter/recipesinfra: releaseRelease-related requests and toolingRelease-related requests and toolingteam-infraOwned by Infrastructure teamOwned by Infrastructure teamtriaged-infraTriaged by Infrastructure teamTriaged by Infrastructure team
Description
In #168709 we added a workaround, schedule_during_release_override: true:
targets:
- name: Linux docs_publish
schedule_during_release_override: trueUnfortunately it does not completely fix every issue that was originally regressed in #162557, namely now Linux docs_publish is run twice - once on Linux flutter_release_builder, and once on post-submit tasks scheduled after the release builder.
As far as I can tell this has no negative side-effects other than being wasteful (GCS buckets should be the same, output should be the same).
To make everything simpler, both in the recipes, and not having to add code elsewhere, we should just do:
targets:
- name: Linux docs_publish
enabled_branches: [master]
- name: Linux docs_publish_release
scheduler: releaseTo do this:
- Add support for
scheduler: releasein theis is_release_candidate:branch ofrelease_builder.py - Split the target branches in
master - Split the target branches in
flutter-3.32-candidate.0 - Remove
schedule_during_release_override
Metadata
Metadata
Assignees
Labels
P1High-priority issues at the top of the work listHigh-priority issues at the top of the work listc: tech-debtTechnical debt, code quality, testing, etc.Technical debt, code quality, testing, etc.infra: recipesIssues with flutter/recipesIssues with flutter/recipesinfra: releaseRelease-related requests and toolingRelease-related requests and toolingteam-infraOwned by Infrastructure teamOwned by Infrastructure teamtriaged-infraTriaged by Infrastructure teamTriaged by Infrastructure team