Skip to content

[DisplayList] Use impeller::BlendMode rather than a private DlBlendMode enum #165412

@flar

Description

@flar

The 2 enum classes are identical except for the spelling of the values. DlBlendMode used the spelling that Skia used to use for ease of global replacement but now we have an unnecessary duplicate compared to the Impeller version. (Technically it is somewhat a dup of SkBlendMode as well, but we needed our own version for API isolation from Skia.)

We should replace the enum class DlBlendMode defined in DisplayList with just a using DlBlendMode = impeller::BlendMode statement and do the global name replacement to eliminate the need for "conversion" with Impeller.

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Important issues not at the top of the work listc: proposalA detailed proposal for a change to Fluttere: impellerImpeller rendering backend issues and features requestsengineflutter/engine related. See also e: labels.r: fixedIssue is closed as already fixed in a newer versionteam-engineOwned by Engine teamtriaged-engineTriaged by Engine team

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions