Skip to content

dev/bots/analyze_snippet_code.dart does not allow engine to override analysis_options.yaml #160884

New issue
New issue
Open
Open
dev/bots/analyze_snippet_code.dart does not allow engine to override analysis_options.yaml#160884
Labels
P2Important issues not at the top of the work listc: tech-debtTechnical debt, code quality, testing, etc.engineflutter/engine related. See also e: labels.team-infraOwned by Infrastructure teamtriaged-infraTriaged by Infrastructure team
@matanlurey

Description

@matanlurey
matanlurey
opened on Dec 26, 2024

See

flutter/dev/bots/analyze_snippet_code.dart

Lines 998 to 1001 in 29d0435

// Use the same analysis_options.yaml configuration that's used for examples/api.
final File sourceAnalysisOptions = File(
path.join(_flutterRoot, 'examples', 'api', 'analysis_options.yaml'),
);

In flutter/engine#53223, we made an intentional decision to no longer require always_specify_types, and indeed that change is still in effect in the merged monorepo. However, there are scripts that assume certain properties that live outside the engine.

I had to undo style suggestions recommended by @jtmcdole (#160798 (comment)) as a result.

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Important issues not at the top of the work listc: tech-debtTechnical debt, code quality, testing, etc.engineflutter/engine related. See also e: labels.team-infraOwned by Infrastructure teamtriaged-infraTriaged by Infrastructure team

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions