-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Closed
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listd: docs/flutter/flutter/docs, for contributorsflutter/flutter/docs, for contributorsframeworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.r: fixedIssue is closed as already fixed in a newer versionIssue is closed as already fixed in a newer versionteam-frameworkOwned by Framework teamOwned by Framework teamtriaged-frameworkTriaged by Framework teamTriaged by Framework team
Description
Use case
Use case: Engineers get up-to-date information from the DeviceLab readme
The https://github.com/flutter/flutter/blob/master/dev/devicelab/README.md file explains how to run DeviceLab tests locally. But it omits some important details that differ from the usual behaviour of running tests engineers are familiar with:
- By default, the failing tests are autoretried. It makes sense to mention this as it is likely any engineer running the tests locally does not want that behaviour and wants to disable it.
- The DeviceLab test runner automatically reboots the Android and iOS devices it runs tests on. While this behaviour currently can't be disabled, it still makes sense to tell engineers about it, as otherwise, devices (seemingly) randomly restarting looks like a serious bug.
As an engineer, it would be very useful to have these things mentioned in the documentation.
Proposal
Proposal: Update the DeviceLab readme
Update the DeviceLab Readme at https://github.com/flutter/flutter/blob/master/dev/devicelab/README.md and add a warning about reboots and a small section about disabling the automatic retries for failed tests.
Metadata
Metadata
Assignees
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listd: docs/flutter/flutter/docs, for contributorsflutter/flutter/docs, for contributorsframeworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.r: fixedIssue is closed as already fixed in a newer versionIssue is closed as already fixed in a newer versionteam-frameworkOwned by Framework teamOwned by Framework teamtriaged-frameworkTriaged by Framework teamTriaged by Framework team