-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Closed
flutter/engine
#57015Closed
Copy link
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listc: proposalA detailed proposal for a change to FlutterA detailed proposal for a change to Fluttere: impellerImpeller rendering backend issues and features requestsImpeller rendering backend issues and features requeststeam-engineOwned by Engine teamOwned by Engine teamtriaged-engineTriaged by Engine teamTriaged by Engine team
Description
Today they are shared_ptr<Pipeline<PipelineDescriptor>>. This inflates the size of Command which are created hundreds of times per frame and also causes a synchronization when ~shared_ptr is called. The ContentContext should be keeping these alive and Command's are ephemeral so there is no need for it to have an owning reference to the pipeline.
This is even the case for runtime effects: https://github.com/flutter/engine/blob/main/impeller/entity/contents/content_context.cc#L572-L583
spawned from: #159177
Metadata
Metadata
Assignees
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listc: proposalA detailed proposal for a change to FlutterA detailed proposal for a change to Fluttere: impellerImpeller rendering backend issues and features requestsImpeller rendering backend issues and features requeststeam-engineOwned by Engine teamOwned by Engine teamtriaged-engineTriaged by Engine teamTriaged by Engine team