Skip to content

[iOS] Clean up method calls in FlutterViewController initialisers and dealloc #157140

Description

@cbracken

Calling helper methods in initialisers and dealloc is unsafe. Methods should only ever be called on fully initialised objects since methods can be overridden in subclasses.

The iOS FlutterViewController calls methods from both its initialisers and its dealloc. We should fix this, but it's probably also an indication that FlutterViewController is doing too much.

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Important issues not at the top of the work listc: tech-debtTechnical debt, code quality, testing, etc.engineflutter/engine related. See also e: labels.platform-iosiOS applications specificallyteam-iosOwned by iOS platform teamtriaged-iosTriaged by iOS platform team

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions