Skip to content

Refactor video_player_android/example/integration_test to _not_ use MiniController #156424

@matanlurey

Description

@matanlurey

In video_player_test.dart @stuartmorgan writes:

// TODO(stuartmorgan): Remove the use of MiniController in tests, as that is
// testing test code; tests should instead be written directly against the
// platform interface. (These tests were copied from the app-facing package
// during federation and minimally modified, which is why they currently use the
// controller.)
import 'package:video_player_example/mini_controller.dart';

I'd like to do this, as I want to add more integration tests of the video_player generally, and I agree with Stuart's take.

Metadata

Metadata

Assignees

Labels

P2Important issues not at the top of the work listc: tech-debtTechnical debt, code quality, testing, etc.p: video_playerThe Video Player pluginplatform-androidAndroid applications specificallyteam-androidOwned by Android platform team

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions