Skip to content

Remove all nullable generics in plugin Pigeon definitions #155891

@stuartmorgan-g

Description

@stuartmorgan-g

Now that #97848 is fixed, we should sweep all of our plugins for any nullable generics that were nullable only because of that issue (that's probably any nullable generic, but there may be some rare exceptions). Many have a TODO annotated with #97848, but we shouldn't assume they all have an annotation.

In general I would expect that we can just:

  • Remove the nullability from generics.
  • Update to the latest version of Pigeon.
  • Remove any casting on the Dart side.
  • Do any incidental changes for intervening Pigeon breaking changes (e.g., setup->setUp)

Since most of our plugins are using Obj-C and Java on the native side still, native changes will likely be minimal.

This will give us a nearly-free improvement in type safety, and also avoid having other developers who look to our plugins as examples thinking they still need the same workaround.

Metadata

Metadata

Assignees

Labels

Bot is counting down the days until it unassigns the issueP1High-priority issues at the top of the work listpackageflutter/packages repository. See also p: labels.team-ecosystemOwned by Ecosystem teamtriaged-ecosystemTriaged by Ecosystem team

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions