-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Closed
flutter/engine
#54450Closed
Copy link
Labels
P3Issues that are less important to the Flutter projectIssues that are less important to the Flutter projecte: local-engine-developmentLocal builds of the engine working betterLocal builds of the engine working betterengineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.platform-macBuilding on or for macOS specificallyBuilding on or for macOS specificallyr: fixedIssue is closed as already fixed in a newer versionIssue is closed as already fixed in a newer versionteam-engineOwned by Engine teamOwned by Engine teamtriaged-engineTriaged by Engine teamTriaged by Engine team
Description
Right now committing to the Flutter engine (supposedly) requires Oracle's java installed:

https://github.com/flutter/engine/blob/main/docs/contributing/Setting-up-the-Engine-development-environment.md
Which (appears?) to require those of us who work at companies to sign some agreement with oracle to be able to use java?
https://www.java.com/en/download/

As far as I can tell, the formatter just wants to run java, which users already have installed due to Android Studio or other sources.
flutter has a bunch of logic to find java:
| static Java? find({ |
We don't need anything quite that fancy, but even just falling back to
/Applications/Android\ Studio.app/Contents/jbr/Contents/Home/bin/java would be sufficient on mac to find java for the vast majority of potential Flutter committers.
My guess is that java just comes installed on Google Corp and thus this doesn't show up for Googlers. 🤷
FYI @reidbaker
Metadata
Metadata
Assignees
Labels
P3Issues that are less important to the Flutter projectIssues that are less important to the Flutter projecte: local-engine-developmentLocal builds of the engine working betterLocal builds of the engine working betterengineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.platform-macBuilding on or for macOS specificallyBuilding on or for macOS specificallyr: fixedIssue is closed as already fixed in a newer versionIssue is closed as already fixed in a newer versionteam-engineOwned by Engine teamOwned by Engine teamtriaged-engineTriaged by Engine teamTriaged by Engine team