-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Open
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listplatform-iosiOS applications specificallyiOS applications specificallyteam-iosOwned by iOS platform teamOwned by iOS platform teamtriaged-iosTriaged by iOS platform teamTriaged by iOS platform team
Description
Adding a SemanticsAction to an ancestor node of an iOS platform view can cause the platform view to be incorrectly positioned.
To reproduce:
- Basics
- Setup your local environment for iOS development (e.g. install Xcode)
cd dev/integration_tests/ios_platform_view_testsopen ios/Runner.xcworkspacein Xcode- Open
PlatformViewUITests
- Passing configuration:
- Run the test as is
- Witness the test passing
- On this line wrap
UiKitViewin aSemanticswidget adding it any non-scrolling action (adjustingconstas needed), say,onIncrease, like so:
child: Semantics(
onIncrease: () {},
child: UiKitView(viewType: 'platform_text_field'),
),
- Rerun the test in Xcode
- Witness the test failing on this line with the following error:
Failed to failed to scroll to visible (by AX action) TextField, {{46.5, 115.0}, {300.0, 50.0}}, identifier: 'platform_view[0]', value: Platform Text Field, error: Error kAXErrorCannotComplete performing AXAction kAXScrollToVisibleAction on element AX element pid: 88534, elementOrHash.elementID: 4546916864.36. (Underlying Error: Error kAXErrorCannotComplete performing AXAction kAXScrollToVisibleAction on element AX element pid: 88534, elementOrHash.elementID: 4546916864.36)
Breadcrumbs:
- The problem starts with this line, where the presence of an action alters the value if
isFocusable. - From @jmagman: the problem manifests as an incorrectly positioned platform view.
- From @jmagman: detailed instructions for how to repro with a custom engine build.
Expected behavior
Simply adding an action to an ancestor of a platform view should not alter the platform view's position on the screen.
Metadata
Metadata
Assignees
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listplatform-iosiOS applications specificallyiOS applications specificallyteam-iosOwned by iOS platform teamOwned by iOS platform teamtriaged-iosTriaged by iOS platform teamTriaged by iOS platform team