Skip to content

[CP-stable] Remove TextEditingController private member access (#149042)  #149210

Description

@LongCatIsLooong

Issue Link

#148692

Target

stable

PR Link

#149208

Changelog Description

Fixes an EditableText crash that happens with a custom TextEditingController which only implements the TextEditingController interface.

Impacted Users

Apps that uses a custom TextEditingController that implements TextEditingController

Impact Description

Production apps crash if the user gives an EditableText a custom TextEditingControllor class that implements TextEditingControllor.

Workaround

The crash does not happen if the user extends TextEditingControllor, but it's not always desirable / feasible. The class could be already extending a different base class.

Risk

low

Test Coverage

yes

Validation Steps

Run the test in the PR, or follow the repro steps in #148692

Metadata

Metadata

Assignees

Labels

cp: approvedApproved cherry-pick requestcp: reviewCherry-picks in the review queue

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions