Steps to reproduce

This is more of an analytical code issue, but the issue is visible in generated glyph atlases using the stb implementation.

To reproduce:

1. Use the stb text atlas implementation.
2. In come situations characters will appear like they have their bottoms cut off.

Using renderdoc on the subsequent binary, one can see the Glyphs in the atlas are not laid out correctly in relation to the padding between glyphs.

Expected results

Glyphs shouldn't be cut off along the bottom.

Actual results

Glyphs sometimes cut off along their bottom.

Code sample

I believe the issue is in the following section of code:

   if (!has_color || DISABLE_COLOR_FONT_SUPPORT) {
     stbtt_MakeGlyphBitmap(typeface_stb->GetFontInfo(), output,
                          location.size.width - kPadding,
                          location.size.height - kPadding,
                           bitmap->GetRowBytes(), scale_x, scale_y, glyph.index);

Note the - kPadding.

At this point, the location used is the entry describing the glyph in the atlas, but it does not include padding, so the subtraction of kPadding is not necessary.

Screenshots or Video

Logs

[Paste your logs here]

Flutter Doctor output

[Paste your output here]