Skip to content

[Impeller] delete --enable-impeller-vulkan and --enable-impeller-opengles #142725

@gaaclarke

Description

@gaaclarke

Instead of making these flags that people have to specify when compiling the engine we should make them fixed based on the target platform.

We have hooked up SwiftShader and ANGLE on macOS, the default for macOS builds should include them.

By having multiple build variants, it makes our testing story harder. For example, someone could be happily running impeller_unittests against metal and not realize they broke vulkan.

A less drastic step would just be to change these values to be default on for macOS.

cc @chinmaygarde

Metadata

Metadata

Assignees

Labels

P2Important issues not at the top of the work listc: tech-debtTechnical debt, code quality, testing, etc.e: impellerImpeller rendering backend issues and features requeststeam-engineOwned by Engine teamtriaged-engineTriaged by Engine team

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions