Skip to content

[Impeller] add assertion that golden images are generated #142657

@gaaclarke

Description

@gaaclarke

The way skia gold works with our CI, it's not a failure to fail to generate golden images. We should add an assert that checks the results of impeller_golden_tests to make sure it generates N images.

Given the status quo we are at risk that impeller_golden_tests will get broken and it will go unnoticed.

Metadata

Metadata

Assignees

No one assigned

    Labels

    e: impellerImpeller rendering backend issues and features requeststeam-engineOwned by Engine team

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions