Linux license starts failing when "download_android_deps": false is applied #141461
Description
Linux linux_license has been configured as "download_android_deps": false, however the gclient_variables is not populated to builds from recipes side. (The recipe populates the gclient_variables via a build property, but for standalone targets gclient_variables is not a property.)
The consequence is that Linux linux_license has been actually running as "download_android_deps": true. This can be confirmed by any CI build: those dependencies with 'condition': 'download_android_deps' are being downloaded though they are not expected. (Linux linux_license example)
After a recipe fix (wip: https://flutter-review.googlesource.com/c/recipes/+/53902) where the "download_android_deps": false is indeed populated to build config, the target Linux linux_license starts failing: (example build)
============================= ERROR =============================
The license is excluding a different number of files than previously.
This is only expected when new non-source files have been introduced.
Verify that all the newly ignored files are definitely not shipped with
any binaries that we compile (including impellerc and Wasm).
If the changes look correct, update this file:
ci/licenses_golden/excluded_files
For more information, see the script in:
https://github.com/flutter/engine/tree/main/tools/licenses
--- flutter/ci/licenses_golden/excluded_files 2024-01-10 13:46:42.863327776 -0800
+++ out/license_script_output/excluded_files 2024-01-10 13:55:29.109535098 -0800
@@ -1742,13 +1742,12 @@
../../../third_party/abseil-cpp/absl/utility/utility_test.cc
../../../third_party/abseil-cpp/absl_hardening_test.cc
../../../third_party/abseil-cpp/conanfile.py
../../../third_party/abseil-cpp/create_lts.py
../../../third_party/abseil-cpp/generate_def_files.py
../../../third_party/abseil-cpp/roll_abseil.py
-../../../third_party/android_embedding_dependencies
../../../third_party/android_tools
../../../third_party/angle/.clang-format
../../../third_party/angle/.git
../../../third_party/angle/.gitattributes
../../../third_party/angle/.gitignore
../../../third_party/angle/.gn
@@ -2635,13 +2634,12 @@
../../../third_party/freetype2/src/winfonts/module.mk
../../../third_party/freetype2/src/winfonts/rules.mk
../../../third_party/freetype2/tests
../../../third_party/freetype2/vms_make.com
../../../third_party/google_fonts_for_unit_tests
../../../third_party/googletest
-../../../third_party/gradle
../../../third_party/harfbuzz/.ci/requirements.txt
../../../third_party/harfbuzz/.clang-format
../../../third_party/harfbuzz/.editorconfig
../../../third_party/harfbuzz/.git
../../../third_party/harfbuzz/.github
../../../third_party/harfbuzz/AUTHORS
@@ -2836,13 +2834,12 @@
../../../third_party/icu/source/tools/pkgdata/sources.txt
../../../third_party/icu/source/tools/toolutil/BUILD.bazel
../../../third_party/icu/source/tools/toolutil/Makefile.in
../../../third_party/icu/source/tools/toolutil/sources.txt
../../../third_party/icu/source/tools/tzcode/Makefile.in
../../../third_party/icu/source/tools/tzcode/readme.txt
-../../../third_party/java
../../../third_party/libcxx/.clang-format
../../../third_party/libcxx/.clang-tidy
../../../third_party/libcxx/.git
../../../third_party/libcxx/.gitignore
../../../third_party/libcxx/CMakeLists.txt
../../../third_party/libcxx/CREDITS.TXT
=================================================================