-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Closed
Labels
a: tests"flutter test", flutter_test, or one of our tests"flutter test", flutter_test, or one of our testsengineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.r: fixedIssue is closed as already fixed in a newer versionIssue is closed as already fixed in a newer versionteam-engineOwned by Engine teamOwned by Engine team
Description
The LoggingSocketTest.UseSyslogOnFuchsia unit test is failing due to log packets on Fuchsia being in an unexpected format:
[ RUN ] LoggingSocketTest.UseSyslogOnFuchsia
../../flutter/fml/logging_unittests.cc:123: Failure
Expected equality of these values:
severity
Which is: '0' (48, 0x30)
packet.metadata.severity
Which is: 'p' (112, 0x70)
../../flutter/fml/logging_unittests.cc:124: Failure
Value of: packet.message
Expected: ends with "test message"
Actual: ""
../../flutter/fml/logging_unittests.cc:125: Failure
Expected equality of these values:
tags
Which is: {}
packet.tags
Which is: { "\xD3\0\0\0\0\0\04\0\x3\x80\0\0\0\0tid\0\0\0\0\09\xD3\0\0\0\0\0\0F\0\a\x80\f\x80\0\0message\0test mes", "age\0\0\0\0V\0\x4\x80\x14\x80\0\0file\0\0\0\0logging_unittests.cc\0\0\0\04\0\x4\x80\0\0\0\0line\0\0\0\0\x94\0\0\0\0\0\0\0\xE0HX4\xF8\x1\0\0;\0\0\0\0\0\0\0\x1\0\0\0\0\0\0\0c\x9D\a\xF6" "1\x3\0\0\x18\0\0\0\0\0\0\0\x1\0\0\0" }
../../flutter/fml/logging_unittests.cc:123: Failure
Expected equality of these values:
severity
Which is: '@' (64, 0x40)
packet.metadata.severity
Which is: 'p' (112, 0x70)
../../flutter/fml/logging_unittests.cc:124: Failure
Value of: packet.message
Expected: ends with "hello"
Actual: "\x18"
../../flutter/fml/logging_unittests.cc:125: Failure
Expected equality of these values:
tags
Which is: {}
packet.tags
Which is: { "\xD3\0\0\0\0\0\04\0\x3\x80\0\0\0\0tid\0\0\0\0\09\xD3\0\0\0\0\0\06\0\a\x80\x5\x80\0\0message\0hello\0\0\0", "\0\x4\x80 \x80\0\0file\0\0\0\0flutter/fml/logging_unittests.cc4\0\x4\x80\0\0\0\0line\0\0\0\0\x98\0\0\0\0\0\0\0\xE0HX4\xF8\x1\0\0;\0\0\0\0\0\0\0\x1\0\0\0\0\0\0\0c\x9D\a\xF6" "1\x3\0" }
../../flutter/fml/logging_unittests.cc:123: Failure
Expected equality of these values:
severity
Which is: 'P' (80, 0x50)
packet.metadata.severity
Which is: 'p' (112, 0x70)
../../flutter/fml/logging_unittests.cc:124: Failure
Value of: packet.message
Expected: ends with "logging"
Actual: "\x18"
../../flutter/fml/logging_unittests.cc:125: Failure
Expected equality of these values:
tags
Which is: {}
packet.tags
Which is: { "\xD3\0\0\0\0\0\04\0\x3\x80\0\0\0\0tid\0\0\0\0\09\xD3\0\0\0\0\0\06\0\a\x80\a\x80\0\0message\0logging\0", "\0\x4\x80 \x80\0\0file\0\0\0\0flutter/fml/logging_unittests.cc4\0\x4\x80\0\0\0\0line\0\0\0\0\x9C\0\0\0\0\0\0\0\xE0HX4\xF8\x1\0\0;\0\0\0\0\0\0\0\x1\0\0\0\0\0\0\0c\x9D\a\xF6" "1\x3\0" }
../../flutter/fml/logging_unittests.cc:107: Failure
Expected equality of these values:
(0)
Which is: 0
res
Which is: -22
../../flutter/fml/logging_unittests.cc:123: Failure
Expected equality of these values:
severity
Which is: '/' (47, 0x2F)
packet.metadata.severity
Which is: '\0'
../../flutter/fml/logging_unittests.cc:124: Failure
Value of: packet.message
Expected: ends with "Another message"
Actual: "file"
../../flutter/fml/logging_unittests.cc:125: Failure
Expected equality of these values:
tags
Which is: {}
packet.tags
Which is: { "\xD3\0\0\0\0\0\0\0\0\x3\x80\0\0\0\0pHX4\xF8\x1\0\0\xF\0\0\0\0\0\0\0\x1\0\a\x80\a\x80\0\0c\x93\a\xF6" "1\x3\0\0\x14\0\0\0\0\0\0\0", "\0", "\x80 \x80\0" }
[ FAILED ] LoggingSocketTest.UseSyslogOnFuchsia (1 ms)
e.g. flutter/engine#49517
This is because Fuchsia moved to structured logging, which changes the format of the log packets. There is not a supported way to parse these packets outside of the Fuchsia repository, so this test should probably be removed.
Additional context in b/315973146
Metadata
Metadata
Assignees
Labels
a: tests"flutter test", flutter_test, or one of our tests"flutter test", flutter_test, or one of our testsengineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.r: fixedIssue is closed as already fixed in a newer versionIssue is closed as already fixed in a newer versionteam-engineOwned by Engine teamOwned by Engine team