Skip to content

"Updating project for Xcode compatibility" - Don't lower LastUpgradeCheck #137855

Description

@EnduringBeta

Is there an existing issue for this?

Steps to reproduce

I think this is a step in the Flutter iOS build process, but I'm not totally sure. If it's not Flutter's doing, please let me know.

  1. Grab this repo branch
  2. On macOS, ensure that project.pbxproj and/or Runner.xcscheme have a LastUpgradeCheck of 1500.
    • (This value will only be relevant at time of writing as the most recent Xcode version and would need to be increased upon future Xcode releases, probably.)
  3. Build for iOS/run on an iOS device.
  4. Observe that the files have their LastUpgradeCheck downgraded to an older version.

Expected results

It would be nice if when it observed a different LastUpgradeCheck it could also detect if the value is higher than what it wants to set it to.

I may be naive on the inner workings of the build process for why this occurs.

It creates diffs in my repo whenever I switch between Xcode and Android Studio, which is annoying. I need to use Xcode sometimes, especially when it updates and needs to run some stuff before building works again.

Actual results

Downgrade

Code sample

See repo. Here's where I set the LastUpgradeCheck higher for testing: https://github.com/EnduringBeta/flutter-bug/blob/xcode-compatibility/ios/Runner.xcodeproj/xcshareddata/xcschemes/Runner.xcscheme#L3

Screenshots or Video

No response

Logs

Logs
Let me know if you want these

Flutter Doctor output

Doctor output
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.13.9, on macOS 14.1 23B74 darwin-arm64, locale en-US)
[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.1)
[✓] Xcode - develop for iOS and macOS (Xcode 15.0.1)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2022.3)
[✓] Connected device (3 available)
[✓] Network resources

• No issues found!

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Important issues not at the top of the work listfound in release: 3.13Found to occur in 3.13found in release: 3.17Found to occur in 3.17has reproducible stepsThe issue has been confirmed reproducible and is ready to work onplatform-iosiOS applications specificallyplatform-macosBuilding on or for macOS specificallyt: xcode"xcodebuild" on iOS and general Xcode project managementteam-iosOwned by iOS platform teamtoolAffects the "flutter" command-line tool. See also t: labels.triaged-iosTriaged by iOS platform team

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions