-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Closed
flutter/engine
#46434Closed
Copy link
Labels
P1High-priority issues at the top of the work listHigh-priority issues at the top of the work listc: tech-debtTechnical debt, code quality, testing, etc.Technical debt, code quality, testing, etc.e: impellerImpeller rendering backend issues and features requestsImpeller rendering backend issues and features requeststeam-engineOwned by Engine teamOwned by Engine teamtriaged-engineTriaged by Engine teamTriaged by Engine team
Description
@jonahwilliams and I believe that, at least on Vulkan, we are now enabling validation errors on debug mode, i.e. debug builds of the engine. That's valuable because not only will it run in most of our unit tests, end users that run the engine in debug mode will get/log these GL errors.
This issue is to be consistent with Vulkan (and perhaps Metal), and run GL_CHECK on debug mode.
(Currently it only runs on --unopt, which AFAICT most engine developers don't actively use/isn't tested)
Metadata
Metadata
Assignees
Labels
P1High-priority issues at the top of the work listHigh-priority issues at the top of the work listc: tech-debtTechnical debt, code quality, testing, etc.Technical debt, code quality, testing, etc.e: impellerImpeller rendering backend issues and features requestsImpeller rendering backend issues and features requeststeam-engineOwned by Engine teamOwned by Engine teamtriaged-engineTriaged by Engine teamTriaged by Engine team