-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Closed
flutter/engine
#45918Labels
P1High-priority issues at the top of the work listHigh-priority issues at the top of the work liste: impellerImpeller rendering backend issues and features requestsImpeller rendering backend issues and features requestsengineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.r: fixedIssue is closed as already fixed in a newer versionIssue is closed as already fixed in a newer versionteam-engineOwned by Engine teamOwned by Engine teamtriaged-engineTriaged by Engine teamTriaged by Engine team
Description
In #133506 it was discovered that the interactive playgrounds tests were broken for over a month and no one noticed. We should turn this on in CI. We can't do it yet because it is blocked on #133506
The following patch should enable the CI tests once they can pass.
--- a/testing/run_tests.py
+++ b/testing/run_tests.py
@@ -492,7 +492,7 @@ def run_cc_tests(build_dir, executable_filter, coverage, capture_core_dump):
'METAL_DEBUG_ERROR_MODE': '0', # Enables metal validation.
'METAL_DEVICE_WRAPPER_TYPE': '1', # Enables metal validation.
})
- # Impeller tests are only supported on macOS for now.
+
run_engine_executable(
build_dir,
'impeller_unittests',
@@ -508,6 +508,25 @@ def run_cc_tests(build_dir, executable_filter, coverage, capture_core_dump):
]
)
+ # Run one interactive Vulkan tests with validation on.
+ run_engine_executable(
+ build_dir,
+ 'impeller_unittests',
+ executable_filter,
+ [
+ '--enable_vulkan_validation', '--playground_timeout_ms=4000',
+ '--enable_playground', '--gtest_filter=*ColorWheel/Vulkan'
+ ],
+ coverage=coverage,
+ extra_env=extra_env,
+ # TODO(117122): Remove this allowlist.
+ # https://github.com/flutter/flutter/issues/114872
+ allowed_failure_output=[
+ '[MTLCompiler createVertexStageAndLinkPipelineWithFragment:',
+ '[MTLCompiler pipelineStateWithVariant:',
+ ]
+ )
+Metadata
Metadata
Assignees
Labels
P1High-priority issues at the top of the work listHigh-priority issues at the top of the work liste: impellerImpeller rendering backend issues and features requestsImpeller rendering backend issues and features requestsengineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.r: fixedIssue is closed as already fixed in a newer versionIssue is closed as already fixed in a newer versionteam-engineOwned by Engine teamOwned by Engine teamtriaged-engineTriaged by Engine teamTriaged by Engine team