-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Closed
flutter/engine
#45654Closed
Copy link
Labels
P1High-priority issues at the top of the work listHigh-priority issues at the top of the work liste: impellerImpeller rendering backend issues and features requestsImpeller rendering backend issues and features requeststeam-engineOwned by Engine teamOwned by Engine teamtriaged-engineTriaged by Engine teamTriaged by Engine team
Description
note: edited by @matanlurey.
Today we reset individual cmd buffers, but that can be really slow. We should follow the best practices in https://arm-software.github.io/vulkan_best_practice_for_mobile_developers/samples/performance/command_buffer_usage/command_buffer_usage_tutorial.html and create 1 cmd pool per thread/per frame. Once the pool usage is complete (via fence waiter), we can reset and recycle.
To reproduce this:
# Don't use a unopt build, as we will be profiling C++ code.
cd $ENGINE
./flutter/tools/gn --android --android-cpu=arm64 --enable-vulkan --no-stripped --no-lto
# "fl" is a local flutter tool, i.e. $FRAMEWORK
fl run --local-engine=$ENGINE/out/android_debug_arm64 --local-engine-host=host_debug_unopt_arm64dev/integration_tests/flutter_gallery/android/app/build.gradle in the android { ... } section:
+ packagingOptions{
+ doNotStrip "**/*.so"
+ }dev/integration_tests/flutter_gallery/android/app/src/main/AndroidManifest.xml:
+ <meta-data
+ android:name="io.flutter.embedding.android.EnableImpeller"
+ android:value="true" />Metadata
Metadata
Assignees
Labels
P1High-priority issues at the top of the work listHigh-priority issues at the top of the work liste: impellerImpeller rendering backend issues and features requestsImpeller rendering backend issues and features requeststeam-engineOwned by Engine teamOwned by Engine teamtriaged-engineTriaged by Engine teamTriaged by Engine team
