-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Closed
Labels
P0Critical issues such as a build break or regressionCritical issues such as a build break or regressionc: performanceRelates to speed or footprint issues (see "perf:" labels)Relates to speed or footprint issues (see "perf:" labels)c: regressionIt was better in the past than it is nowIt was better in the past than it is nowdependency: dartDart team may need to help usDart team may need to help usengineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.perf: speedPerformance issues related to (mostly rendering) speedPerformance issues related to (mostly rendering) speedteam-engineOwned by Engine teamOwned by Engine team
Description
SkiaPerf is reporting that the 90%-ile and average frame build time regressed on complex_layout_scroll_perf_bad_ios__timeline_summary by about 30%:
The report is on the commit here 3b8f6c4, containing a Skia roll with unrelated commits, and a manual Dart roll flutter/engine#43472 with commits here:
https://dart.googlesource.com/sdk.git/+log/2d98d9e27dae..0b07debd5862
Unfortunately, it's a large Dart roll with many VM changes. Marking P0 only for help with identifying any culprits, if possible.
Metadata
Metadata
Assignees
Labels
P0Critical issues such as a build break or regressionCritical issues such as a build break or regressionc: performanceRelates to speed or footprint issues (see "perf:" labels)Relates to speed or footprint issues (see "perf:" labels)c: regressionIt was better in the past than it is nowIt was better in the past than it is nowdependency: dartDart team may need to help usDart team may need to help usengineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.perf: speedPerformance issues related to (mostly rendering) speedPerformance issues related to (mostly rendering) speedteam-engineOwned by Engine teamOwned by Engine team