Skip to content

Regression in frame build time in complex_layout_scroll_perf #130339

@zanderso

Description

@zanderso

SkiaPerf is reporting that the 90%-ile and average frame build time regressed on complex_layout_scroll_perf_bad_ios__timeline_summary by about 30%:

https://flutter-flutter-perf.skia.org/e/?begin=1688490769&end=1689086966&keys=Xfce5bf9b2126b8e2e20d155f0f31b1d5&requestType=0&selected=commit%3D35614%26name%3D%252Carch%253Dintel%252Cbranch%253Dmaster%252Cconfig%253Ddefault%252Cdevice_type%253DiPhone_11%252Cdevice_version%253Dnone%252Chost_type%253Dmac%252Csub_result%253D90th_percentile_frame_build_time_millis%252Ctest%253Dcomplex_layout_scroll_perf_bad_ios__timeline_summary%252C&xbaroffset=35614

The report is on the commit here 3b8f6c4, containing a Skia roll with unrelated commits, and a manual Dart roll flutter/engine#43472 with commits here:

https://dart.googlesource.com/sdk.git/+log/2d98d9e27dae..0b07debd5862

Unfortunately, it's a large Dart roll with many VM changes. Marking P0 only for help with identifying any culprits, if possible.

Metadata

Metadata

Assignees

No one assigned

    Labels

    P0Critical issues such as a build break or regressionc: performanceRelates to speed or footprint issues (see "perf:" labels)c: regressionIt was better in the past than it is nowdependency: dartDart team may need to help usengineflutter/engine related. See also e: labels.perf: speedPerformance issues related to (mostly rendering) speedteam-engineOwned by Engine team

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions