Skip to content

Null check error in vm_snapshot_analysis #130009

@zanderso

Description

@zanderso

Starting in the Engine -> Framework roll here #129914, builds started failing with:

Null check operator used on a null value
            #0      _ProgramInfoBuilder.createInfoNodeFor (package:vm_snapshot_analysis/v8_profile.dart:450:53)
            #1      _ProgramInfoBuilder.getInfoNodeFor (package:vm_snapshot_analysis/v8_profile.dart:374:14)
            #2      _ProgramInfoBuilder.createInfoNodeFor (package:vm_snapshot_analysis/v8_profile.dart:444:23)
            #3      _ProgramInfoBuilder.getInfoNodeFor (package:vm_snapshot_analysis/v8_profile.dart:374:14)
            #4      _ProgramInfoBuilder.createInfoNodeFor (package:vm_snapshot_analysis/v8_profile.dart:419:54)
            #5      _ProgramInfoBuilder.getInfoNodeFor (package:vm_snapshot_analysis/v8_profile.dart:374:14)
            #6      ListIterable.forEach (dart:_internal/iterable.dart:39:13)
            #7      _ProgramInfoBuilder.build (package:vm_snapshot_analysis/v8_profile.dart:338:16)
            #8      toProgramInfo (package:vm_snapshot_analysis/v8_profile.dart:282:8)
            #9      _treemapFromSnapshot (package:vm_snapshot_analysis/treemap.dart:158:27)
            #10     treemapFromJson (package:vm_snapshot_analysis/treemap.dart:85:5)
            #11     SizeAnalyzer.analyzeZipSizeAndAotSnapshot (package:flutter_tools/src/base/analyze_size.dart:123:59)
            #12     AndroidGradleBuilder._performCodeSizeAnalysis (package:flutter_tools/src/android/gradle.dart:623:60)
            #13     AndroidGradleBuilder.buildGradleApp (package:flutter_tools/src/android/gradle.dart:604:15)
            <asynchronous suspension>
            #14     AndroidGradleBuilder.buildApk (package:flutter_tools/src/android/gradle.dart:242:5)
            <asynchronous suspension>
            #15     BuildApkCommand.runCommand (package:flutter_tools/src/commands/build_apk.dart:116:5)
            <asynchronous suspension>
            #16     FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart:1297:27)
            <asynchronous suspension>
            #17     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
            <asynchronous suspension>
            #18     CommandRunner.runCommand (package:args/command_runner.dart:212:13)
            <asynchronous suspension>
            #19     FlutterCommandRunner.runCommand.<anonymous closure> (package:flutter_tools/src/runner/flutter_command_runner.dart:339:9)
            <asynchronous suspension>
            #20     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
            <asynchronous suspension>
            #21     FlutterCommandRunner.runCommand (package:flutter_tools/src/runner/flutter_command_runner.dart:285:5)
            <asynchronous suspension>
            #22     run.<anonymous closure>.<anonymous closure> (package:flutter_tools/runner.dart:115:9)
            <asynchronous suspension>
            #23     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
            <asynchronous suspension>
            #24     main (package:flutter_tools/executable.dart:90:3)
            <asynchronous suspension>

It looks like this was introduced by the Dart roll here:

with the change: https://dart.googlesource.com/sdk.git/+/a4f59b8c205e69f902a1ea146e440eaa9c9c211e

cc @rmacnak-google

Metadata

Metadata

Assignees

No one assigned

    Labels

    P0Critical issues such as a build break or regressiondependency: dartDart team may need to help us

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions