Skip to content

[pigeon] Incorrect memory semantics for Obj-C collections #127401

@stuartmorgan-g

Description

@stuartmorgan-g

This code:
https://github.com/flutter/packages/blob/5bc20b0b42c83bcc01abc98a52a0311e3679de99/packages/pigeon/lib/objc_generator.dart#L968-L969

is incorrect; NSArray and NSDictionary should be copy (since they can be passed mutable versions; they are COW, so it's only less efficient in cases where the current behavior would be wrong anyway).

Metadata

Metadata

Labels

P1High-priority issues at the top of the work listp: pigeonrelated to pigeon messaging codegen toolpackageflutter/packages repository. See also p: labels.platform-iosiOS applications specificallyteam-iosOwned by iOS platform teamtriaged-iosTriaged by iOS platform team

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions