-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Closed
Labels
d: tools_metadataDevTools related - issues for the flutter/tools_metadata repoDevTools related - issues for the flutter/tools_metadata repof: material designflutter/packages/flutter/material repository.flutter/packages/flutter/material repository.found in release: 3.7Found to occur in 3.7Found to occur in 3.7frameworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.has reproducible stepsThe issue has been confirmed reproducible and is ready to work onThe issue has been confirmed reproducible and is ready to work on
Description
Some links to icons from the Icons class are broken in the IDE tooltips.
I found that the following icons have broken links:
Icons.arrow_outward(all variants)Icons.assignment_addIcons.assist_walker(all variants)Icons.barcode_readerIcons.battery_1throughIcons.battery_6(all variants)Icons.blind(all variants)Icons.brightness_1throughIcons.brightness_7(all variants)Icons_diversity(all variants)
The actual documentation (i.e. https://api.flutter.dev/flutter/material/Icons/diversity_1-constant.html) has no issues.
Could the links be validated somehow, so that they don't break in the future?
Steps to Reproduce
- Switch to the beta channel (some icons don't seem to exist on stable yet?)
- Open the code sample in an IDE (I used VSCode)
- Type
Icons.divas value for the Icon() constructor - A documentation tooltip opens in the IDE, which shows suggestions for icons
- The tooltip has broken image previews for all icons in the list above
Expected results: The documentation tooltip should show a preview of the icon.
Actual results: The documentation tooltip cannot render the icon preview because of a broken link.
Code sample
import 'package:flutter/material.dart';
final Widget icon = Icon(); // enter Icons.diversity_1 hereLogs
[✓] Flutter (Channel beta, 3.7.0-1.1.pre, on macOS 12.2.1 21D62 darwin-x64,
locale en-BE)
• Flutter version 3.7.0-1.1.pre on channel beta at
/Users/navaronbracke/Documents/flutter
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision e599f02c7a (13 days ago), 2022-12-08 01:07:24 +0530
• Engine revision 4971c5b2e7
• Dart version 2.19.0 (build 2.19.0-444.1.beta)
• DevTools version 2.20.0
[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
• Android SDK at /Users/navaronbracke/Library/Android/sdk
• Platform android-33, build-tools 33.0.0
• ANDROID_HOME = /Users/navaronbracke/Library/Android/sdk
• Java binary at: /Applications/Android
Studio.app/Contents/jre/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build
11.0.13+0-b1751.21-8125866)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 13.4.1)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Build 13F100
• CocoaPods version 1.11.2
[✓] Chrome - develop for the web
• Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[✓] Android Studio (version 2021.3)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build
11.0.13+0-b1751.21-8125866)
[✓] VS Code (version 1.74.1)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 3.54.0
[✓] Connected device (2 available)
• macOS (desktop) • macos • darwin-x64 • macOS 12.2.1 21D62 darwin-x64
• Chrome (web) • chrome • web-javascript • Google Chrome 108.0.5359.124
[✓] HTTP Host Availability
• All required HTTP hosts are available
• No issues found!
Metadata
Metadata
Assignees
Labels
d: tools_metadataDevTools related - issues for the flutter/tools_metadata repoDevTools related - issues for the flutter/tools_metadata repof: material designflutter/packages/flutter/material repository.flutter/packages/flutter/material repository.found in release: 3.7Found to occur in 3.7Found to occur in 3.7frameworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.has reproducible stepsThe issue has been confirmed reproducible and is ready to work onThe issue has been confirmed reproducible and is ready to work on
