Skip to content

"default arguments on virtual or override methods are prohibited" google-default-arguments warnings #115522

@jmagman

Description

@jmagman
❌ Failures for clang-tidy on /b/s/w/ir/cache/builder/src/flutter/flow/layers/layer_raster_cache_item.cc:
/b/s/w/ir/cache/builder/src/flutter/flow/layers/layer_raster_cache_item.cc:143:28: error: default arguments on virtual or override methods are prohibited [google-default-arguments,-warnings-as-errors]
bool LayerRasterCacheItem::TryToPrepareRasterCache(const PaintContext& context,
                           ^

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8797288801511583233/+/u/test:_lint_android_debug_arm64/stdout

❌ Failures for clang-tidy on /b/s/w/ir/cache/builder/src/flutter/flow/layers/display_list_raster_cache_item.cc:
/b/s/w/ir/cache/builder/src/flutter/flow/layers/display_list_raster_cache_item.cc:141:34: error: default arguments on virtual or override methods are prohibited [google-default-arguments,-warnings-as-errors]
bool DisplayListRasterCacheItem::TryToPrepareRasterCache(
                                 ^

❌ Failures for clang-tidy on /b/s/w/ir/cache/builder/src/flutter/display_list/display_list_utils.cc:
/b/s/w/ir/cache/builder/src/flutter/display_list/display_list_utils.cc:349:30: error: default arguments on virtual or override methods are prohibited [google-default-arguments,-warnings-as-errors]
bool RTreeBoundsAccumulator::restore(
                             ^

❌ Failures for clang-tidy on /b/s/w/ir/cache/builder/src/flutter/display_list/display_list_builder.cc:
/b/s/w/ir/cache/builder/src/flutter/display_list/display_list_builder.cc:911:26: error: default arguments on virtual or override methods are prohibited [google-default-arguments,-warnings-as-errors]
void DisplayListBuilder::drawImageRect(const sk_sp<DlImage> image,
                         ^

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8797288801511583249/+/u/test:_lint_host_debug/stdout
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8797288801518646705/+/u/test:_lint_host_debug/stdout

❌ Failures for clang-tidy on /Volumes/Work/s/w/ir/cache/builder/src/flutter/shell/platform/darwin/ios/ios_surface_software.mm:
/Volumes/Work/s/w/ir/cache/builder/src/flutter/shell/platform/darwin/ios/ios_surface_software.mm:35:46: error: default arguments on virtual or override methods are prohibited [google-default-arguments,-warnings-as-errors]
std::unique_ptr<Surface> IOSSurfaceSoftware::CreateGPUSurface(GrDirectContext* gr_context) {

❌ Failures for clang-tidy on /Volumes/Work/s/w/ir/cache/builder/src/flutter/impeller/compiler/spirv_sksl.cc:
/Volumes/Work/s/w/ir/cache/builder/src/flutter/impeller/compiler/spirv_sksl.cc:7:1: error: do not use namespace using-directives; use using-declarations instead [google-build-using-namespace,-warnings-as-errors]
using namespace spv;
^
/Volumes/Work/s/w/ir/cache/builder/src/flutter/impeller/compiler/spirv_sksl.cc:8:1: error: do not use namespace using-directives; use using-declarations instead [google-build-using-namespace,-warnings-as-errors]
using namespace SPIRV_CROSS_NAMESPACE;
^
/Volumes/Work/s/w/ir/cache/builder/src/flutter/impeller/compiler/spirv_sksl.cc:405:27: error: default arguments on virtual or override methods are prohibited [google-default-arguments,-warnings-as-errors]
std::string CompilerSkSL::image_type_glsl(const SPIRType& type, uint32_t id) {
                          ^

❌ Failures for clang-tidy on /Volumes/Work/s/w/ir/cache/builder/src/flutter/lib/ui/painting/image_generator.cc:
/Volumes/Work/s/w/ir/cache/builder/src/flutter/lib/ui/painting/image_generator.cc:63:33: error: default arguments on virtual or override methods are prohibited [google-default-arguments,-warnings-as-errors]
bool BuiltinSkiaImageGenerator::GetPixels(
                                ^
/Volumes/Work/s/w/ir/cache/builder/src/flutter/lib/ui/painting/image_generator.cc:123:38: error: default arguments on virtual or override methods are prohibited [google-default-arguments,-warnings-as-errors]
bool BuiltinSkiaCodecImageGenerator::GetPixels(
                                     ^

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8797288801518646689/+/u/test:_lint_ios_debug_sim/stdout

https://google.github.io/styleguide/cppguide.html#Default_Arguments

See flutter/engine#37698

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Important issues not at the top of the work listc: contributor-productivityTeam-specific productivity, code health, technical debt.engineflutter/engine related. See also e: labels.team-engineOwned by Engine teamtriaged-engineTriaged by Engine team

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions