Skip to content

[Impeller] uniform offset needs to account for samplers #115246

@jonahwilliams

Description

@jonahwilliams

See https://github.com/flutter/engine/blob/master/impeller/entity/contents/runtime_effect_contents.cc#L188

If a sampler uniform occurs before a float uniform, then all float uniforms will be off by one. This was observed when comparing two different shader programs that generated the same MSL but different uniform ordering in the IPLR file

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Important issues not at the top of the work liste: impellerImpeller rendering backend issues and features requestsengineflutter/engine related. See also e: labels.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions