Skip to content

[CP] Convert the ImpellerC command line arguments to UTF-8 on Windows #112497

@christopherfujino

Description

@christopherfujino

Note this is a follow up to #111689, which was already merged to the RC branch. It was discovered that there was an additional issue when trying to update CI to include a unicode char in the path: https://flutter-review.googlesource.com/c/recipes/+/34140

issue_link

#107590

Commit Hash

6d0f53a33532b1c5a426776fe52afb178f8a58dd

Target

stable

pr_link

flutter/engine#36451

Impacted Users

Flutter developers on Windows developing in non-ascii file paths

Impact Description

While building a flutter app on Windows in a file path with non-ascii characters, the tool will crash.

Workaround

Rename directory to not contain unicode characters.

Risk

low

Test Coverage

no

Validation Steps

To validate, on a Windows machine, introduce a unicode character into the project path and try to run flutter run -d windows.

Metadata

Metadata

Assignees

Labels

cp: approvedApproved cherry-pick requestcp: merge-to-betaCherry-picks that should be merged to betacp: merge-to-stableCherry-picks that should be merged to stablecp: reviewCherry-picks in the review queue

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions