Skip to content

impellerc should be codesigned for macOS #111764

New issue
New issue
Closed
christopherfujino/codesign.py
#3
Closed
impellerc should be codesigned for macOS#111764
christopherfujino/codesign.py
#3
Assignees
XilaiZhang
Milestone
Impeller on iOS
@jmagman

Description

@jmagman
jmagman
opened on Sep 16, 2022

impellerc is being executed on the host machine, so should be codesigned/notarized on macOS to avoid the "Developer unknown" popup when the SDK is downloaded from the website (because it is quarantined).

flutter/packages/flutter_tools/lib/src/build_system/targets/shader_compiler.dart

Lines 171 to 173 in 25e88cb

final List<String> cmd = <String>[
impellerc.path,
target.target,

Instead of being in

flutter/dev/conductor/core/lib/src/codesign.dart

Line 183 in 25e88cb

Future<List<String>> get binariesWithoutEntitlements async {

it should be in

flutter/dev/conductor/core/lib/src/codesign.dart

Line 140 in 25e88cb

Future<List<String>> get binariesWithEntitlements async {

Introduced in #102551

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions