Skip to content

Remove rethrow from Dart plugin registration handler #106322

@stuartmorgan-g

Description

@stuartmorgan-g

Currently the (non-web) Dart plugin registration catches exceptions and logs, but then re-throws. This means that if there's an exception in one plugin, all plugins that come after it alphabetically won't have their Dart registration run. This is a Dart version of the issue we already had and fixed with Java registration, which caused a lot of confusion before we changed it to catch exceptions.

We should keep the logging and remove the rethrow, so that only the problematic plugin will be broken, not other plugins.

Metadata

Metadata

Labels

P2Important issues not at the top of the work lista: pluginsSupport for writing, building, and running plugin packagestoolAffects the "flutter" command-line tool. See also t: labels.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions