Skip to content

Fix FrameTimingsRecorderTest tests in host_debug #103757

@zanderso

Description

@zanderso

Currently, we're not running run_tests.py 'engine' tests for host_debug. A couple are failing. See: https://ci.chromium.org/raw/build/logs.chromium.org/flutter/led/zra_google.com/c2d35aa2766f095359f71c5f9a8d1ccad996d53596553f65d7113649707fcd6a/+/build.proto?server=chromium-swarm.appspot.com

[ RUN      ] FrameTimingsRecorderTest.ThrowWhenRecordRasterBeforeBuildEnd

[WARNING] ../../third_party/googletest/googletest/src/gtest-death-test.cc:1124:: Death tests use fork(), which is unsafe particularly in a threaded context. For this test, Google Test detected 3 threads. See https://github.com/google/googletest/blob/master/docs/advanced.md#death-tests-and-threads for more explanation and suggested solutions, especially if this is the last message you see before your test times out.
../../flutter/flow/frame_timings_recorder_unittests.cc:147: Failure
Death test: recorder->RecordRasterStart(raster_start)
    Result: failed to die.
 Error msg:
[  DEATH   ] 
[  FAILED  ] FrameTimingsRecorderTest.ThrowWhenRecordRasterBeforeBuildEnd (2 ms)
[ RUN      ] FrameTimingsRecorderTest.ThrowWhenRecordBuildBeforeVsync

[WARNING] ../../third_party/googletest/googletest/src/gtest-death-test.cc:1124:: Death tests use fork(), which is unsafe particularly in a threaded context. For this test, Google Test detected 3 threads. See https://github.com/google/googletest/blob/master/docs/advanced.md#death-tests-and-threads for more explanation and suggested solutions, especially if this is the last message you see before your test times out.
../../flutter/flow/frame_timings_recorder_unittests.cc:134: Failure
Death test: recorder->RecordBuildStart(build_start)
    Result: failed to die.
 Error msg:
[  DEATH   ] 
[  FAILED  ] FrameTimingsRecorderTest.ThrowWhenRecordBuildBeforeVsync (1 ms)

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Important issues not at the top of the work listengineflutter/engine related. See also e: labels.team: skip-testAn issue used to track tests that are skipped.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions