-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Closed
Closed
Copy link
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listc: tech-debtTechnical debt, code quality, testing, etc.Technical debt, code quality, testing, etc.toolAffects the "flutter" command-line tool. See also t: labels.Affects the "flutter" command-line tool. See also t: labels.
Description
In a previous attempt this was breaking in google3:
google3:///[third_party/dart/flutter_tools/lib/src/debug_adapters/flutter_adapter.dart:27](https://cs.corp.google.com/piper///depot/google3/third_party/dart/flutter_tools/lib/src/debug_adapters/flutter_adapter.dart?l=27&ws=tap-prod-presubmit/179932707&snapshot=7):11: Error: The parameter 'ipv6' can't have a value of 'null' because of its type 'bool', but the implicit default value is 'null'.
Try adding either an explicit non-'null' default value or the 'required' modifier.
super.ipv6,
^^^^
google3:///[third_party/dart/flutter_tools/lib/src/debug_adapters/flutter_adapter.dart:28](https://cs.corp.google.com/piper///depot/google3/third_party/dart/flutter_tools/lib/src/debug_adapters/flutter_adapter.dart?l=28&ws=tap-prod-presubmit/179932707&snapshot=7):11: Error: The parameter 'enableDds' can't have a value of 'null' because of its type 'bool', but the implicit default value is 'null'.
Try adding either an explicit non-'null' default value or the 'required' modifier.
super.enableDds,
^^^^^^^^^
google3:///[third_party/dart/flutter_tools/lib/src/debug_adapters/flutter_adapter.dart:29](https://cs.corp.google.com/piper///depot/google3/third_party/dart/flutter_tools/lib/src/debug_adapters/flutter_adapter.dart?l=29&ws=tap-prod-presubmit/179932707&snapshot=7):11: Error: The parameter 'enableAuthCodes' can't have a value of 'null' because of its type 'bool', but the implicit default value is 'null'.
Try adding either an explicit non-'null' default value or the 'required' modifier.
super.enableAuthCodes,
^^^^^^^^^^^^^^^
google3:///[third_party/dart/flutter_tools/lib/src/debug_adapters/flutter_test_adapter.dart:27](https://cs.corp.google.com/piper///depot/google3/third_party/dart/flutter_tools/lib/src/debug_adapters/flutter_test_adapter.dart?l=27&ws=tap-prod-presubmit/179932707&snapshot=7):11: Error: The parameter 'ipv6' can't have a value of 'null' because of its type 'bool', but the implicit default value is 'null'.
Try adding either an explicit non-'null' default value or the 'required' modifier.
super.ipv6,
^^^^
google3:///[third_party/dart/flutter_tools/lib/src/debug_adapters/flutter_test_adapter.dart:28](https://cs.corp.google.com/piper///depot/google3/third_party/dart/flutter_tools/lib/src/debug_adapters/flutter_test_adapter.dart?l=28&ws=tap-prod-presubmit/179932707&snapshot=7):11: Error: The parameter 'enableDds' can't have a value of 'null' because of its type 'bool', but the implicit default value is 'null'.
Try adding either an explicit non-'null' default value or the 'required' modifier.
super.enableDds,
^^^^^^^^^
google3:///[third_party/dart/flutter_tools/lib/src/debug_adapters/flutter_test_adapter.dart:29](https://cs.corp.google.com/piper///depot/google3/third_party/dart/flutter_tools/lib/src/debug_adapters/flutter_test_adapter.dart?l=29&ws=tap-prod-presubmit/179932707&snapshot=7):11: Error: The parameter 'enableAuthCodes' can't have a value of 'null' because of its type 'bool', but the implicit default value is 'null'.
Try adding either an explicit non-'null' default value or the 'required' modifier.
super.enableAuthCodes,
^^^^^^^^^^^^^^^
There were no issues in open-source land, though. We need to investigate why this wasn't working in google3.
Metadata
Metadata
Assignees
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listc: tech-debtTechnical debt, code quality, testing, etc.Technical debt, code quality, testing, etc.toolAffects the "flutter" command-line tool. See also t: labels.Affects the "flutter" command-line tool. See also t: labels.