Skip to content

Create better names for the DisplayList transform methods #100175

@flar

Description

@flar

The Dispatcher transform methods have an odd set of names that is hard to keep consistent. In general the Dispatcher/Builder names follow a verb() or verbNoun() format. For transforms we have:

  • translate
  • scale
  • rotate
  • skew
  • transform2DAffine
  • transformFullPerspective
  • transformReset (to be added in a pending PR)

The last three are odd in that they use transform as either a noun or a verb for a nounVerb or verbAdverb format.

Perhaps better names would be:

  • concat2DAffine[Transform]
  • concatFullPerspective[Transform]
  • resetTransform

Metadata

Metadata

Assignees

No one assigned

    Labels

    P3Issues that are less important to the Flutter projectc: proposalA detailed proposal for a change to Flutterengineflutter/engine related. See also e: labels.team-engineOwned by Engine teamtriaged-engineTriaged by Engine team

    Type

    No type

    Projects

    Status

    🛠️ Internals

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions