switched test to drawing images and fixed rerasterization logic

gaaclarke · gaaclarke · commit c2e333e5bac2 · 2025-12-17T15:21:48.000-08:00
diff --git a/engine/src/flutter/impeller/display_list/aiks_dl_runtime_effect_unittests.cc b/engine/src/flutter/impeller/display_list/aiks_dl_runtime_effect_unittests.cc
@@ -474,9 +474,12 @@ TEST_P(AiksTest, ClippedBackdropFilterWithShader) {
 }
 
 TEST_P(AiksTest, RuntimeEffectImageFilterRotated) {
+  auto image = DlImageImpeller::Make(CreateTextureForFixture("kalimba.jpg"));
+  auto size = image->GetBounds().GetSize();
+
   struct FragUniforms {
     Size size;
-  } frag_uniforms = {.size = Size::MakeWH(400, 400)};
+  } frag_uniforms = {.size = Size(size.width, size.height)};
   auto uniform_data = std::make_shared<std::vector<uint8_t>>();
   uniform_data->resize(sizeof(FragUniforms));
   memcpy(uniform_data->data(), &frag_uniforms, sizeof(FragUniforms));
@@ -506,13 +509,14 @@ TEST_P(AiksTest, RuntimeEffectImageFilterRotated) {
       ImGui::End();
     }
     DisplayListBuilder builder;
-    builder.Translate(200, 200);
+    builder.Translate(size.width * 0.5, size.height * 0.5);
     builder.Rotate(rotation);
-    builder.Translate(-200, -200);
+    builder.Translate(-size.width * 0.5, -size.height * 0.5);
 
     DlPaint paint;
     paint.setImageFilter(runtime_filter);
-    builder.DrawRect(DlRect::MakeXYWH(0, 0, 400, 400), paint);
+    builder.DrawImage(image, DlPoint(0.0, 0.0),
+                      DlImageSampling::kNearestNeighbor, &paint);
 
     return builder.Build();
   };
diff --git a/engine/src/flutter/impeller/renderer/snapshot.h b/engine/src/flutter/impeller/renderer/snapshot.h
@@ -45,11 +45,15 @@ struct Snapshot {
   /// capture the padding.
   bool needs_rasterization_for_runtime_effects = false;
 
-  /// Any snapshot that is scaled should rerasterize because we should be
+  /// Any snapshot that is scaled should re-rasterize because we should be
   /// performing the RuntimeEffect at the resolution of the screen, not the
   /// scaled up or scaled down version of the snapshot.
   bool ShouldRasterizeForRuntimeEffects() const {
-    return !transform.IsTranslationOnly() ||
+    // If the transform has a rotation we don't re-rasterize because we'll lose
+    // the rotation.
+    // TODO(tbd): We should re-rasterize scaled and rotated snapshots.
+    return (!transform.IsTranslationOnly() &&
+            transform.IsTranslationScaleOnly()) ||
            needs_rasterization_for_runtime_effects;
   }
 
