Commit bfc9041
authored
No longer exiting the application when the RegularWindow is destroyed + resolving the window created promise after runWidget (#181339)
This potentially fixes #177715
by:
1. Relying on the test framework to close the app
2. Completing the `windowCreated` future following `runWidget` when
everything is _actually_ ready to go
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.1 parent 9ca1e1d commit bfc9041
1 file changed
Lines changed: 3 additions & 13 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
| 6 | + | |
6 | 7 | | |
7 | 8 | | |
8 | 9 | | |
9 | | - | |
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
17 | | - | |
18 | | - | |
19 | | - | |
20 | | - | |
21 | | - | |
22 | | - | |
23 | | - | |
24 | | - | |
25 | | - | |
26 | 16 | | |
27 | 17 | | |
28 | 18 | | |
| |||
180 | 170 | | |
181 | 171 | | |
182 | 172 | | |
183 | | - | |
| 173 | + | |
184 | 174 | | |
185 | | - | |
186 | 175 | | |
187 | 176 | | |
| 177 | + | |
188 | 178 | | |
189 | 179 | | |
190 | 180 | | |
| |||
0 commit comments