Commit bf18e39
authored
[flutter_tools] Fix arm64e incorrectly matching arm64 in regex check (#184057)
Fixes #184056
The regex `EXCLUDED_ARCHS.*arm64` in `pluginsSupportArmSimulator()`
matches
`arm64e` as a substring, causing Flutter to incorrectly exclude arm64
from
simulator builds when plugins only exclude arm64e.
This adds a word boundary (\\barm64\\b) so that arm64e is no longer a
false
positive match, fixing simulator builds on Apple Silicon Macs.
Also strengthens the existing test assertion to verify arm64 is NOT
added
to EXCLUDED_ARCHS when only arm64e is excluded by plugins.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [AI contribution guidelines] and understand my
responsibilities, or I am not using AI tools.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.1 parent b716540 commit bf18e39
2 files changed
Lines changed: 8 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
572 | 572 | | |
573 | 573 | | |
574 | 574 | | |
575 | | - | |
| 575 | + | |
576 | 576 | | |
577 | 577 | | |
578 | 578 | | |
| |||
Lines changed: 7 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1565 | 1565 | | |
1566 | 1566 | | |
1567 | 1567 | | |
| 1568 | + | |
1568 | 1569 | | |
1569 | | - | |
1570 | | - | |
| 1570 | + | |
| 1571 | + | |
| 1572 | + | |
| 1573 | + | |
| 1574 | + | |
| 1575 | + | |
1571 | 1576 | | |
1572 | 1577 | | |
1573 | 1578 | | |
| |||
0 commit comments