Skip to content

Commit b2e3cc4

Browse files
PiinksPiinks
authored
Revert "[pubspec] Bump Dart SDK constraint to ^3.13.0 (#186957)" (#187209)
This reverts commit df8cb09. - #186957 - Reason for revert: this bumped the framework to an unstable version of Dart and made additional changes beyond the version bump. Attempting to cleanly revert and then will follow up with a bump to 3.12. - Should help (not entirely) with #187204 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
1 parent 7285f2f commit b2e3cc4

161 files changed

Lines changed: 364 additions & 409 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎analysis_options.yaml‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ linter:
6363
- avoid_init_to_null
6464
- avoid_js_rounded_ints
6565
# - avoid_multiple_declarations_per_line # seems to be a stylistic choice we don't subscribe to
66-
66+
- avoid_null_checks_in_equality_operators
6767
# - avoid_positional_boolean_parameters # would have been nice to enable this but by now there's too many places that break it
6868
- avoid_print
6969
# - avoid_private_typedef_functions # we prefer having typedef (discussion in https://github.com/flutter/flutter/pull/16356)
@@ -177,7 +177,7 @@ linter:
177177
- prefer_generic_function_type_aliases
178178
- prefer_if_elements_to_conditional_expressions
179179
- prefer_if_null_operators
180-
# - prefer_initializing_formals
180+
- prefer_initializing_formals
181181
- prefer_inlined_adds
182182
# - prefer_int_literals # conflicts with ./docs/contributing/Style-guide-for-Flutter-repo.md#use-double-literals-for-double-constants
183183
- prefer_interpolation_to_compose_strings
@@ -253,7 +253,7 @@ linter:
253253
- use_enums
254254
- use_full_hex_values_for_flutter_colors
255255
- use_function_type_syntax_for_parameters
256-
256+
- use_if_null_to_convert_nulls_to_bools
257257
- use_is_even_rather_than_modulo
258258
- use_key_in_widget_constructors
259259
- use_late_for_private_fields_and_variables

‎dev/a11y_assessments/pubspec.yaml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ description: A new Flutter project
33
version: 5.0.0+5
44

55
environment:
6-
sdk: ^3.13.0-0
6+
sdk: ^3.10.0-0
77

88
resolution: workspace
99

‎dev/automated_tests/pubspec.yaml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
name: flutter_automated_tests
22

33
environment:
4-
sdk: ^3.13.0-0
4+
sdk: ^3.10.0-0
55

66
resolution: workspace
77

‎dev/benchmarks/complex_layout/pubspec.yaml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ name: complex_layout
22
description: A benchmark of a relatively complex layout.
33

44
environment:
5-
sdk: ^3.13.0-0
5+
sdk: ^3.10.0-0
66

77
resolution: workspace
88

‎dev/benchmarks/imitation_game_flutter/pubspec.yaml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ publish_to: 'none' # Remove this line if you wish to publish to pub.dev
44
version: 1.0.0+1
55

66
environment:
7-
sdk: ^3.13.0-0
7+
sdk: ^3.10.0-0
88

99
resolution: workspace
1010

‎dev/benchmarks/macrobenchmarks/pubspec.yaml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ name: macrobenchmarks
22
description: Performance benchmarks using flutter drive.
33

44
environment:
5-
sdk: ^3.13.0-0
5+
sdk: ^3.10.0-0
66

77
resolution: workspace
88

‎dev/benchmarks/microbenchmarks/pubspec.yaml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ name: microbenchmarks
22
description: Small benchmarks for very specific parts of the Flutter framework.
33

44
environment:
5-
sdk: ^3.13.0-0
5+
sdk: ^3.10.0-0
66

77
resolution: workspace
88

‎dev/benchmarks/multiple_flutters/module/pubspec.yaml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ description: A module that is embedded in the multiple_flutters benchmark test.
44
version: 1.0.0+1
55

66
environment:
7-
sdk: ^3.13.0-0
7+
sdk: ^3.10.0-0
88

99
resolution: workspace
1010

‎dev/benchmarks/platform_channels_benchmarks/pubspec.yaml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ publish_to: 'none' # Remove this line if you wish to publish to pub.dev
55
version: 1.0.0+1
66

77
environment:
8-
sdk: ^3.13.0-0
8+
sdk: ^3.10.0-0
99

1010
resolution: workspace
1111

‎dev/benchmarks/platform_views_layout/pubspec.yaml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ name: platform_views_layout
22
description: A benchmark for platform views.
33

44
environment:
5-
sdk: ^3.13.0-0
5+
sdk: ^3.10.0-0
66

77
resolution: workspace
88

0 commit comments

Comments
 (0)