Check needs_painting in RasterCache::Prepare (#6708)

liyuqian · web-flow · commit a27d2f2bc413 · 2018-10-31T10:51:13.000-07:00
Otherwise, this may trigger `FML_DCHECK(needs_painting())`. We haven't
caused crashes for our users because it probably requires a locally
debug engine build to trigger the assert.
diff --git a/flow/raster_cache.cc b/flow/raster_cache.cc
@@ -164,7 +164,9 @@ void RasterCache::Prepare(PrerollContext* context,
                                   context->texture_registry,
                                   context->raster_cache,
                                   context->checkerboard_offscreen_layers};
-                              layer->Paint(paintContext);
+                              if (layer->needs_painting()) {
+                                layer->Paint(paintContext);
+                              }
                             });
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -164,7 +164,9 @@ void RasterCache::Prepare(PrerollContext* context,`
`164`	`164`	`context->texture_registry,`
`165`	`165`	`context->raster_cache,`
`166`	`166`	`context->checkerboard_offscreen_layers};`
`167`		`- layer->Paint(paintContext);`
	`167`	`+ if (layer->needs_painting()) {`
	`168`	`+ layer->Paint(paintContext);`
	`169`	`+ }`
`168`	`170`	`});`
`169`	`171`	`}`
`170`	`172`	`}`